linux-kernel - Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADYN=9JgNRqs5ghv9_UU0MEEKX_kg+L2KXs3c-tXpw1m0dnxDw@mail.gmail.com>
Date:   Tue, 27 Feb 2018 23:32:45 +0100
From:   Anders Roxell <anders.roxell@...aro.org>
To:     Zong Li <zongbox@...il.com>
Cc:     shuah@...nel.org, Vincent Legoll <vincent.legoll@...il.com>,
        ast@...nel.org, daniel@...earbox.net, mcgrof@...nel.org,
        davem@...emloft.net, Kees Cook <keescook@...omium.org>,
        Fathi Boudra <fathi.boudra@...aro.org>, netdev@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-kselftest@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        zong@...estech.com, greentime@...estech.com
Subject: Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

On 23 February 2018 at 08:05, Zong Li <zongbox@...il.com> wrote:
> 2018-02-23 3:57 GMT+08:00 Anders Roxell <anders.roxell@...aro.org>:
>> On 22 February 2018 at 12:53, Zong Li <zongbox@...il.com> wrote:
>>> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig
>>> to ease disabling it all")', the make kselftest-merge cannot merge the
>>> config dependencies of kselftest to the existing .config file.
>>>
>>> These config dependencies of kselftest need to enable the
>>> 'CONFIG_RUNTIME_TESTING_MENU=y' at the same time.
>>
>> Is this patch needed when patch sha 'f29c79906064 ("lib/Kconfig.debug: enable
>> RUNTIME_TESTING_MENU")' find its way into the kernel ?
>> I think it's in linux-next now.
>
> Thanks. The patch sha 'f29c79906064 ("lib/Kconfig.debug: enable
> RUNTIME_TESTING_MENU")' can resolve the make kselftest-merge
> on default situation, but I think the kselftest-merge should resolve
> the dependencies
> without the prerequisite, it should enable the 'RUNTIME_TESTING_MENU'
> when merging
> the config of some selftests if RUNTIME_TESTING_MENU is not set.

I see your point, but should the be enabled in a common place that
gets included per
default if running kselftest-merge and not in all config fragments?

Cheers,
Anders