linux-kernel - Re: [PATCH] usbip: tools usbip_attach: Fix cryptic error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <8b7b3f6a-4075-e7e3-39ac-51ddb8f961a0@samsung.com>
Date:   Tue, 27 Feb 2018 23:45:57 +0100
From:   Krzysztof Opasiak <k.opasiak@...sung.com>
To:     Shuah Khan <shuahkh@....samsung.com>, valentina.manea.m@...il.com,
        shuah@...nel.org, gregkh@...uxfoundation.org
Cc:     yuyang.du@...el.com, nobuo.iwata@...ixerox.co.jp,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbip: tools usbip_attach: Fix cryptic error messages



On 02/27/2018 11:23 PM, Shuah Khan wrote:
> Attach device error message is cryptic and useless. Fix it to be
> informative.
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>   tools/usb/usbip/src/usbip_attach.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/usb/usbip/src/usbip_attach.c b/tools/usb/usbip/src/usbip_attach.c
> index 7f07b2d50f59..f60738735398 100644
> --- a/tools/usb/usbip/src/usbip_attach.c
> +++ b/tools/usb/usbip/src/usbip_attach.c
> @@ -195,7 +195,8 @@ static int attach_device(char *host, char *busid)
>   
>   	rhport = query_import_device(sockfd, busid);
>   	if (rhport < 0) {
> -		err("query");
> +		err("Attach request for Device %s. Is this device exported?",
> +		    busid);
>   		return -1;
>   	}

The code itself is ok and you may put my:

Reviewed-by: Krzysztof Opasiak <k.opasiak@...sung.com>

but just because of my curiosity, there is a number of places in usbip 
tools where the same level of descriptiveness is used for error message. 
Why did you choose to fix this one not any other or all others?;)

Best regards,
-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics