linux-kernel - Re: [PATCH] nbd: fix return value in error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5abe2722-6f74-04cb-d417-fc960cb1997f@embeddedor.com>
Date:   Tue, 27 Feb 2018 15:43:02 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Omar Sandoval <osandov@...ndov.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Josef Bacik <jbacik@...com>, linux-block@...r.kernel.org,
        nbd@...er.debian.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nbd: fix return value in error handling path



On 02/26/2018 05:01 PM, Omar Sandoval wrote:
> On Mon, Feb 12, 2018 at 11:14:55AM -0600, Gustavo A. R. Silva wrote:
>> It seems that the proper value to return in this particular case is the
>> one contained into variable new_index instead of ret.
>>
>> Addresses-Coverity-ID: 1465148 ("Copy-paste error")
>> Fixes: e46c7287b1c2 ("nbd: add a basic netlink interface")
> Reviewed-by: Omar Sandoval <osandov@...com>

Thanks, Omar.
--
Gustavo

>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>   drivers/block/nbd.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
>> index 5f2a424..86258b0 100644
>> --- a/drivers/block/nbd.c
>> +++ b/drivers/block/nbd.c
>> @@ -1591,7 +1591,7 @@ static int nbd_genl_connect(struct sk_buff *skb, struct genl_info *info)
>>   			if (new_index < 0) {
>>   				mutex_unlock(&nbd_index_mutex);
>>   				printk(KERN_ERR "nbd: failed to add new device\n");
>> -				return ret;
>> +				return new_index;
>>   			}
>>   			nbd = idr_find(&nbd_index_idr, new_index);
>>   		}
>> -- 
>> 2.7.4
>>