linux-kernel - Re: [PATCH] mm:swap: do not check readahead flag with THP anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180227232943.GC168047@rodete-desktop-imager.corp.google.com>
Date:   Wed, 28 Feb 2018 08:29:43 +0900
From:   Minchan Kim <minchan@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm <linux-mm@...ck.org>, lkml <linux-kernel@...r.kernel.org>,
        Hugh Dickins <hughd@...gle.com>,
        "Huang, Ying" <ying.huang@...el.com>
Subject: Re: [PATCH] mm:swap: do not check readahead flag with THP anon

On Wed, Feb 28, 2018 at 08:26:11AM +0900, Minchan Kim wrote:
> Huang reported PG_readahead flag marked PF_NO_COMPOUND so that
> we cannot use the flag for THP page. So, we need to check first
> whether page is THP or not before using TestClearPageReadahead
> in lookup_swap_cache.
> 
> This patch fixes it.
> 
> Furthermore, swap_[cluster|vma]_readahead cannot mark PG_readahead
> for newly allocated page because the allocated page is always a
> normal page, not THP at this moment. So let's clean it up, too.
> 
> Cc: Hugh Dickins <hughd@...gle.com>
> Cc: "Huang, Ying" <ying.huang@...el.com>
> Signed-off-by: Minchan Kim <minchan@...nel.org>

 Link:http://lkml.kernel.org/r/874lm83zho.fsf@yhuang-dev.intel.com