linux-kernel - Re: [PATCH v3] rtc: cros-ec: return -ETIME when refused to set alarms in the past

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Feb 2018 10:53:02 +0800
From:   JeffyChen <jeffy.chen@...k-chips.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>,
        linux-kernel@...r.kernel.org
CC:     zyw@...k-chips.com, briannorris@...gle.com, dianders@...gle.com,
        jwerner@...omium.org, linux-rtc@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH v3] rtc: cros-ec: return -ETIME when refused to set alarms
 in the past

Hi guys,

On 02/27/2018 10:47 AM, Jeffy Chen wrote:
>   		/* Don't set an alarm in the past. */
>   		if ((u32)alarm_time < current_time)
Oops, i'm a idiot, forgot to use '<='... will resend it.
> -			alarm_offset = EC_RTC_ALARM_CLEAR;
> -		else
> -			alarm_offset = (u32)alarm_time - current_time;
> +			return -ETIME;
> +
> +		alarm_offset = (u32)alarm_time - current_time;
>   	}