linux-kernel - Re: [PATCH] checkpatch: avoid error report caused by syzbot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Feb 2018 08:37:31 -0800
From:   Joe Perches <joe@...ches.com>
To:     Yisheng Xie <xieyisheng1@...wei.com>, apw@...onical.com,
        akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: avoid error report caused by syzbot

On Wed, 2018-02-28 at 17:10 +0800, Yisheng Xie wrote:
> syzbot request to add his reported-by when fix the bug find by syzbot.
> However, it will trigger a error when use checkpatch:
> 
>   ERROR: Unrecognized email address: 'syzbot+d7a918a7a8e1c952bc36@...kaller.appspotmail.com'
> 
> For it include '+' in email and make regular expression works abnomal. Fix
> it by adding check for syzbot.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>

Nack.

There's a proper patch already in -next

commit 14e45b3ecdb03211ab32656cd84e66fd6a28343e
Author: Joe Perches <joe@...ches.com>
Date:   Thu Feb 22 09:59:45 2018 +1100

    checkpatch: improve parse_email signature checking
    
    Bare email addresses with non alphanumeric characters require escape
    quoting before being substituted in the parse_email routine.
    
    e.g. Reported-by: syzbot+bbd8e9a06452cc48059b@...kaller.appspotmail.com
    
    Do so.
    
    Link: http://lkml.kernel.org/r/1518631805.3678.12.camel@perches.com