linux-kernel - Re: [PATCH] arm64: dts: juno: fix size of GICv2m MSI frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Feb 2018 15:51:34 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Sudeep Holla <sudeep.holla@....com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, Liviu Dudau <liviu.dudau@....com>,
        Marc Zyngier <marc.zyngier@....com>
Subject: Re: [PATCH] arm64: dts: juno: fix size of GICv2m MSI frames

Hi Sudeep,

Cheers for sorting it out...

On 28/02/18 15:48, Sudeep Holla wrote:
> Currently the size of GICv2m MSI frames are listed as 4kB while the
> Juno TRM specifies 64kB for each of these MSI frames.
> 
> Though the devices connected themself might just use the first 4kB,

s/themself/themselves/

> to be consistent with the genaral practice of 64kB boundary alignment

s/genaral/general/

> to all the devices, lets keep the size as 64kB. This might also help
> in avoiding any surprise when passing the device to a VM.
> 
> This patch increase the size of each GICv2m MSI frames from 4kB to 64kB
> as per the specification.

Reviewed-by: Robin Murphy <robin.murphy@....com>

> Cc: Liviu Dudau <liviu.dudau@....com>
> Cc: Robin Murphy <robin.murphy@....com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> ---
>   arch/arm64/boot/dts/arm/juno-base.dtsi | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> index f8088c45b060..eb749c50a736 100644
> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> @@ -72,25 +72,25 @@
>   		v2m_0: v2m@0 {
>   			compatible = "arm,gic-v2m-frame";
>   			msi-controller;
> -			reg = <0 0 0 0x1000>;
> +			reg = <0 0 0 0x10000>;
>   		};
>   
>   		v2m@...00 {
>   			compatible = "arm,gic-v2m-frame";
>   			msi-controller;
> -			reg = <0 0x10000 0 0x1000>;
> +			reg = <0 0x10000 0 0x10000>;
>   		};
>   
>   		v2m@...00 {
>   			compatible = "arm,gic-v2m-frame";
>   			msi-controller;
> -			reg = <0 0x20000 0 0x1000>;
> +			reg = <0 0x20000 0 0x10000>;
>   		};
>   
>   		v2m@...00 {
>   			compatible = "arm,gic-v2m-frame";
>   			msi-controller;
> -			reg = <0 0x30000 0 0x1000>;
> +			reg = <0 0x30000 0 0x10000>;
>   		};
>   	};
>   
>