linux-kernel - Re: [PATCH v16 06/11] fw_cfg: handle fw_cfg_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180228193142-mutt-send-email-mst@kernel.org>
Date:   Wed, 28 Feb 2018 19:32:53 +0200
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Marc-André Lureau <marcandre.lureau@...hat.com>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de, bhe@...hat.com,
        slp@...hat.com, somlo@....edu, xiaolong.ye@...el.com
Subject: Re: [PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error

> @@ -557,7 +566,10 @@ static int fw_cfg_sysfs_probe(struct platform_device *pdev)
>  		goto err_probe;
>  
>  	/* get revision number, add matching top-level attribute */
> -	fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev));
> +	err = fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev));
> +	if (err < 0)
> +		goto err_probe;
> +
>  	fw_cfg_rev = le32_to_cpu(rev);
>  	err = sysfs_create_file(fw_cfg_top_ko, &fw_cfg_rev_attr.attr);
>  	if (err)

So on this one, maybe we should just drop this attribute.
Does anyone use it?
Removing it will speed up boot slightly.

> -- 
> 2.16.1.73.g5832b7e9f2