linux-kernel - Re: [RFC PATCH v2] ptr_ring: linked list fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <909327f0-52b8-5c3c-47fe-7b1b71dca196@redhat.com>
Date:   Wed, 28 Feb 2018 11:39:15 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        John Fastabend <john.fastabend@...il.com>,
        netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [RFC PATCH v2] ptr_ring: linked list fallback



On 2018年02月28日 11:28, Jason Wang wrote:
>>> Well I believe the main user for this is qdisc, which use skb array. 
>>> And we
>>> can not use what implemented in this patch directly for sk_buff 
>>> without some
>>> changes on the data structure.
>> Why not? skb has next and prev pointers at 1st two fields:
>>
>> struct sk_buff {
>>          union {
>>                  struct {
>>                          /* These two members must be first. */
>>                          struct sk_buff          *next;
>>                          struct sk_buff          *prev;
>> ...
>> }
>>
>> so it's just a question of casting to struct plist.
>
> Well, then the casting can only be done in skb_array implementation? 

Ok, could be done in ptr ring. But still looks tricky, because of the 
different meaning of prev and last.

Thanks