linux-kernel - Re: [PATCH V4 2/2] thermal: imx: add i.MX7 thermal sensor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1519838731.16494.8.camel@nxp.com>
Date:   Wed, 28 Feb 2018 19:25:31 +0200
From:   Leonard Crestez <leonard.crestez@....com>
To:     Anson Huang <Anson.Huang@....com>, <rui.zhang@...el.com>,
        <edubezval@...il.com>, <shawnguo@...nel.org>
CC:     <Linux-imx@....com>, <linux-pm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, <fabio.estevam@....com>,
        <linux@...linux.org.uk>, <kernel@...gutronix.de>,
        Lothar Waßmann <LW@...O-electronics.de>
Subject: Re: [PATCH V4 2/2] thermal: imx: add i.MX7 thermal sensor support

On Sat, 2018-02-24 at 16:02 +0800, Anson Huang wrote:
> This patch adds i.MX7 thermal sensor support, most
> of the i.MX7 thermal sensor functions are same with
> i.MX6 except the registers offset/layout, so we move
> those registers offset/layout definitions to soc data
> structure.
> 
> i.MX7 uses single calibration data @25C, the calibration
> data is located at OCOTP offset 0x4F0, bit[17:9], the
> formula is as below:
> 
> Tmeas = (Nmeas - n1) + 25; n1 is the fuse value for 25C.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> Signed-off-by: Bai Ping <ping.bai@....com>

On imx7d (also 6sx and 6ul) OCOTP read will hang silently if the ocotp
clk is not enabled. For example this can happen if imx_thermal is built
as a module or probes after unused clocks are disabled.

This driver has support for reading ocotp values through the ocotp
nvmem driver (which handles clks properly). Since imx7d is a new
compatible string for upstream maybe you could just make new-style
bindings mandatory and drop the changes to imx_init_from_tempmon_data?

See commit 2067b757e972 ("ARM: dts: imx6ul: Add imx6ul-tempmon")

--
Regards,
Leonard