[<prev] [next>] [day] [month] [year] [list]
Message-ID: <e484c42f-4fe6-10f5-dab8-cfd749911486@infradead.org>
Date: Wed, 28 Feb 2018 10:59:58 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Arvind Prasanna <arvindprasanna@...il.com>
Cc: Kate Stewart <kstewart@...uxfoundation.org>,
Thomas Gleixner <tglx@...utronix.de>,
Philippe Ombredanne <pombredanne@...b.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: Update ncurses package names for
menuconfig
On 02/28/2018 09:39 AM, Arvind Prasanna wrote:
> Hi Randy:
>
> On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
>> The package name is ncurses-devel for Redhat based distros
>> and libncurses-devel for Debian based distros.
>
> The above lines are part of the commit message and the patch says to install either ncurses-devel or libncurses-dev based on the user's Linux distribution. Would you prefer I add my commit message lines to the patch as well?
>
> Thanks,
>
> Arvind.
>
>
> On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <rdunlap@...radead.org <mailto:rdunlap@...radead.org>> wrote:
>
> On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> > The package name is ncurses-devel for Redhat based distros
> > and libncurses-devel for Debian based distros.
>
> ^^^^^^^^^^^^^^^^ That's not what the patch says. Please clarify.
For Debian-based distros, is it libncurses-devel (above) or is it
libncurses-dev (as below)? [latter is without the ending "el"]
And what about the other few hundred distros? (rhetorical)
> >
> > Signed-off-by: Arvind Prasanna <arvindprasanna@...il.com <mailto:arvindprasanna@...il.com>>
> > ---
> > scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> > index a10bd9d..4353e40 100755
> > --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> > +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> > @@ -55,7 +55,8 @@ EOF
> > echo " *** required header files." 1>&2
> > echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
> > echo " *** " 1>&2
> > - echo " *** Install ncurses (ncurses-devel) and try again." 1>&2
> > + echo " *** Install ncurses (ncurses-devel or libncurses-dev 1>&2
> > + *** depending on your distribution) and try again." 1>&2
> > echo " *** " 1>&2
> > exit 1
> > fi
--
~Randy
Powered by blists - more mailing lists