linux-kernel - Re: Regression in IPMI on 4.15.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc401118-8398-5985-3cb0-9a63bfe26148@acm.org>
Date:   Wed, 28 Feb 2018 13:07:40 -0600
From:   Corey Minyard <minyard@....org>
To:     Laura Abbott <labbott@...hat.com>
Cc:     openipmi-developer@...ts.sourceforge.net,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Regression in IPMI on 4.15.6

On 02/28/2018 08:17 AM, Corey Minyard wrote:
> On 02/28/2018 07:53 AM, Corey Minyard wrote:
>> On 02/27/2018 05:55 PM, Laura Abbott wrote:
>>> Hi,
>>>
>>> Fedora got a bug report of a crash in IPMI on 4.15.6
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1549316
>>> Unfortunately, it's only a screenshot but it's fairly
>>> clear. It looks like a panic in the error handling path
>>> in platform_device_unregister. Any ideas?
>>>
>>
>
> You may also run into another issue.  You can pull the
> individual patch at
>
> https://github.com/cminyard/linux-ipmi.git 
> c8a1972e77dbe321ce5ce0247056e727234cbaec

Actually, it needed a few more tweaks.  Can you do change
426fa6179dae677134dfb37b21d057819418515b
instead?  It's "ipmi: Fix some error cleanup issues"

I can send you patches, if you like.  If you could test and get back
to me, that would be great.

BTW, the IPMI setup in your system is incorrect.  SMBIOS says it's at a
memory address, but it's at an I/O address.  And the address given
doesn't appear to be a valid address, the value read doesn't appear
to be a valid value.

-corey

>
> for that fix.
>
> -corey
>
>> Yeah, this is fixed by 174134ac7602 "ipmi_si: Fix error
>> handling of platform device" in mainstream.
>>
>> I guess I need to request a backport of this.
>>
>> Thanks for reporting.
>>
>> -corey
>>
>>
>>> Thanks,
>>> Laura
>>
>>
>