linux-kernel - Re: [PATCH v3 05/10] pwm: add PWM mode to pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180228194429.GD22932@mithrandir>
Date:   Wed, 28 Feb 2018 20:44:30 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     shc_work@...l.ru, kgene@...nel.org, krzk@...nel.org,
        linux@...linux.org.uk, mturquette@...libre.com,
        sboyd@...eaurora.org, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        airlied@...ux.ie, kamil@...as.org, b.zolnierkie@...sung.com,
        jdelvare@...e.com, linux@...ck-us.net, dmitry.torokhov@...il.com,
        rpurdie@...ys.net, jacek.anaszewski@...il.com, pavel@....cz,
        mchehab@...nel.org, sean@...s.org, lee.jones@...aro.org,
        daniel.thompson@...aro.org, jingoohan1@...il.com, milo.kim@...com,
        robh+dt@...nel.org, mark.rutland@....com, corbet@....net,
        nicolas.ferre@...rochip.com, alexandre.belloni@...e-electrons.com,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-hwmon@...r.kernel.org, linux-input@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
        linux-fbdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote:
> Add PWM mode to pwm_config() function. The drivers which uses pwm_config()
> were adapted to this change.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
> ---
>  arch/arm/mach-s3c24xx/mach-rx1950.c  | 11 +++++++++--
>  drivers/bus/ts-nbus.c                |  2 +-
>  drivers/clk/clk-pwm.c                |  3 ++-
>  drivers/gpu/drm/i915/intel_panel.c   | 17 ++++++++++++++---
>  drivers/hwmon/pwm-fan.c              |  2 +-
>  drivers/input/misc/max77693-haptic.c |  2 +-
>  drivers/input/misc/max8997_haptic.c  |  6 +++++-
>  drivers/leds/leds-pwm.c              |  5 ++++-
>  drivers/media/rc/ir-rx51.c           |  5 ++++-
>  drivers/media/rc/pwm-ir-tx.c         |  5 ++++-
>  drivers/video/backlight/lm3630a_bl.c |  4 +++-
>  drivers/video/backlight/lp855x_bl.c  |  4 +++-
>  drivers/video/backlight/lp8788_bl.c  |  5 ++++-
>  drivers/video/backlight/pwm_bl.c     | 11 +++++++++--
>  drivers/video/fbdev/ssd1307fb.c      |  3 ++-
>  include/linux/pwm.h                  |  6 ++++--
>  16 files changed, 70 insertions(+), 21 deletions(-)

I don't think it makes sense to leak mode support into the legacy API.
The pwm_config() function is considered legacy and should eventually go
away. As such it doesn't make sense to integrate a new feature such as
PWM modes into it. All users of pwm_config() assume normal mode, and
that's what pwm_config() should provide.

Anyone that needs something other than normal mode should use the new
atomic PWM API.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)