linux-kernel - Re: [RFT 0/7] firmware: enable caching of firmware for reboot optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Feb 2018 23:18:49 +0200
From:   cantabile <cantabile.desu@...il.com>
To:     "Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:     kubakici@...pl, gregkh@...uxfoundation.org,
        akpm@...ux-foundation.org, linux-wireless@...r.kernel.org,
        keescook@...omium.org, shuah@...nel.org, mfuzzey@...keon.com,
        zohar@...ux.vnet.ibm.com, dhowells@...hat.com,
        pali.rohar@...il.com, tiwai@...e.de, arend.vanspriel@...adcom.com,
        zajec5@...il.com, nbroeking@...com, markivx@...eaurora.org,
        stephen.boyd@...aro.org, broonie@...nel.org,
        dmitry.torokhov@...il.com, dwmw2@...radead.org,
        torvalds@...ux-foundation.org, Abhay_Salunke@...l.com,
        bjorn.andersson@...aro.org, jewalt@...innovations.com,
        oneukum@...e.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [RFT 0/7] firmware: enable caching of firmware for reboot
 optimization

On 28/02/18 20:45, Luis R. Rodriguez wrote:
> On Wed, Feb 28, 2018 at 08:03:26PM +0200, cantabile wrote:
>> On 28/02/18 01:20, Luis R. Rodriguez wrote:
>>> Cantabile, please give these patches a spin and let me know if it fixes
>>> your reported issue. They depend on other pending patches I have in line
>>> waiting to be merged so the easiest I thing I think is for you to test my
>>> 20180227-firmware-cache branch [0], based on Linus' tree. To get that
>>> tree, cd into your Linus git tree and do:
>>>
>>> git remote add mcgrof https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
>>> git checkout -b 20180227-firmware-cache mcgrof/20180227-firmware-cache
>>>
>>> Please let me know if this resolves your issue and thanks for your report.
>>>
>>
>> I confirmed that request_firmware_cache is called, and the firmware is
>> loaded from the cache when resuming from hibernation. The bug is fixed.
> 
> Great, thanks for testing.
> 
> Curious, is it also called if you suspend to RAM instead of just using hibernation?
> 

request_firmware_cache is called when resuming from suspend to RAM.