linux-kernel - Re: [PATCH v3] Documentation: Update ncurses package names for menuconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a83b79e2-3db1-efb4-9122-46708b36b58a@infradead.org>
Date:   Wed, 28 Feb 2018 13:47:22 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arvind Prasanna <arvindprasanna@...il.com>
Cc:     Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Documentation: Update ncurses package names for
 menuconfig

On 02/28/2018 01:32 PM, Arvind Prasanna wrote:
> The package name is ncurses-devel for Redhat based distros
> and libncurses-dev for Debian based distros.
> 
> Signed-off-by: Arvind Prasanna <arvindprasanna@...il.com>

Thanks. Looks good to me.

Acked-by: Randy Dunlap <rdunlap@...radead.org>


> ---
> 
> Changes in v3:
> - Fix a package name in the commit message.
> 
> Changes in v2:
> - Add a missing echo as pointed out by one of the reviewers.
> 
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index a10bd9d..6c0bcd9 100755
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -55,7 +55,8 @@ EOF
>  	    echo " *** required header files."                            1>&2
>  	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
>  	    echo " *** "                                                  1>&2
> -	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
> +	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
> +	    echo " *** depending on your distribution) and try again."    1>&2
>  	    echo " *** "                                                  1>&2
>  	    exit 1
>  	fi
> 


-- 
~Randy