[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180228223421.GM5448@atomide.com>
Date: Wed, 28 Feb 2018 14:34:21 -0800
From: Tony Lindgren <tony@...mide.com>
To: Sekhar Nori <nsekhar@...com>
Cc: Kishon Vijay Abraham I <kishon@...com>,
BenoƮt Cousson <bcousson@...libre.com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Russell King <linux@...linux.org.uk>,
linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability
to MMC1/MMC2 dt node
* Sekhar Nori <nsekhar@...com> [180213 11:11]:
> On Wednesday 07 February 2018 02:51 PM, Kishon Vijay Abraham I wrote:
> > Hi,
> >
> > On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote:
> >> Kishon,
> >>
> >> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:
> >>> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.
> >>>
> >>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> >>
> >> Along with this, dont we need to have
> >>
> >> /delete-property/ mmc-hs200-1_8v;
> >>
> >> for eMMC on Beagle x15 which does not support HS200?
> >>
> >> Or are you planning to depend on lack of pinctrl entries for HS200 to
> >> take care of that?
> >
> > right now it relies on lack of pinctrl entries but I think adding delete
> > property is appropriate. Actually I missed porting the patch that adds
> > /delete-property/.
>
> Actually, thinking more, this should be probably be handled using
> "no-1-8-v" property. Reading the comment above SDHCI_QUIRK2_NO_1_8_V, it
> is specifically meant for the case when system (board) does not support
> 1.8V even when host (controller) does. Which is exactly the case with
> Beagle x15.
OK so that seems to be related to the last patch. I've applied
the first two defconfig patches into omap-for-v4.17/defconfig
and patches up to patch 13/15 into omap-for-v4.17/dt-sdhci.
Kishon, please repost the missing changes or ping me when
the driver dependencies have cleared for further patches to
be applied to enable sdhci.
Regards,
Tony
Powered by blists - more mailing lists