linux-kernel - Re: [PATCH] random: always fill buffer in get_random_bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180228225935.GB3862@thunk.org>
Date:   Wed, 28 Feb 2018 17:59:35 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] random: always fill buffer in get_random_bytes_wait

On Sun, Feb 04, 2018 at 11:07:46PM +0100, Jason A. Donenfeld wrote:
> In the unfortunate event that a developer fails to check the return
> value of get_random_bytes_wait, or simply wants to make a "best effort"
> attempt, for whatever that's worth, it's much better to still fill the
> buffer with _something_ rather than catastrophically failing in the case
> of an interruption. This is both a defense in depth measure against
> inevitable programming bugs, as well as a means of making the API a bit
> more useful.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Thanks, applied.

					- Ted