linux-kernel - Re: [alsa-devel] [PATCH 0/1] Re: Applied "ASoC: topology: Fix logical inversion in set_link_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10bebc9d-3c16-c301-b71b-87786525da14@linux.intel.com>
Date:   Tue, 27 Feb 2018 22:31:23 -0800
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Kirill Marinushkin <k.marinushkin@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Pan Xiuli <xiuli.pan@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [alsa-devel] [PATCH 0/1] Re: Applied "ASoC: topology: Fix logical
 inversion in set_link_hw_format()" to the asoc tree

On 2/27/18 12:33 PM, Kirill Marinushkin wrote:
> Hello Mark, Pierre-Louis, Pan, Liam,
> 
> As there are too much open questions regarding the bclk and fsync inversion in
> set_link_hw_format(), I would like to suggest the alternative solution.
> 
> This solution will fit both use-cases:
> 
> * existing use-cases (Broadwell, etc.)
> * new use-cases (Sound Open Firmware, etc.)
> 
> The solution includes 1 patch for linux + 1 patch for alsa-lib.
> I will send them to this mailing thread.

That looks acceptable to me, Xiuli can you test with with the matching 
change in the SOF topology macros (we can keep the 'slave' in M4 files 
but expand to 'codec_slave' in the .conf to avoid making this exception 
visible).

> 
> Signed-off-by: Kirill Marinushkin <k.marinushkin@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> Cc: Pan Xiuli <xiuli.pan@...ux.intel.com>
> Cc: Liam Girdwood <liam.r.girdwood@...ux.intel.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: alsa-devel@...a-project.org
> 
> Kirill Marinushkin (1):
>    ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()
> 
>   include/uapi/sound/asoc.h | 16 ++++++++++++++--
>   sound/soc/soc-topology.c  | 12 +++++++-----
>   2 files changed, 21 insertions(+), 7 deletions(-)
>