linux-kernel - Re: [PATCH v2 2/2] fs/sysctl: remove redundant link check in proc_sys_link_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180228011557.GC14069@wotan.suse.de>
Date:   Wed, 28 Feb 2018 01:15:57 +0000
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Danilo Krummrich <danilokrummrich@...develop.de>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 2/2] fs/sysctl: remove redundant link check in
 proc_sys_link_fill_cache()

On Tue, Feb 27, 2018 at 03:41:40PM -0800, Kees Cook wrote:
> On Tue, Feb 27, 2018 at 3:31 PM, Danilo Krummrich
> <danilokrummrich@...develop.de> wrote:
> > proc_sys_link_fill_cache() does not need to check whether we're
> > called for a link - it's already done by scan().
> >
> > Signed-off-by: Danilo Krummrich <danilokrummrich@...develop.de>
> 
> Acked-by: Kees Cook <keescook@...omium.org>
> 
> > ---
> > v2: removed 'err' as it's only used for sysctl_follow_link()
> 
> Thanks :)
> 
> Luis, do you have a tree for sysctl, or should these just go via -mm?

-mm has been working beautifully so far.

Now that acks have been collected, Danilo, can you also add the other tags
mentioned and resubmit and add akpm@...ux-foundation.org ?

  Luis