linux-kernel - Re: [PATCH] soc: rockchip: power-domain: remove PM clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4580848.piTrlVmp9H@diego>
Date:   Wed, 28 Feb 2018 12:59:14 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>, wxt@...k-chips.com
Cc:     linux-kernel@...r.kernel.org, tfiga@...omium.org,
        dmitry.torokhov@...il.com, robin.murphy@....com,
        Elaine Zhang <zhangqing@...k-chips.com>,
        linux-rockchip@...ts.infradead.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-arm-kernel@...ts.infradead.org,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] soc: rockchip: power-domain: remove PM clocks

Hi Jeffy,

Am Mittwoch, 28. Februar 2018, 12:11:13 CET schrieb Jeffy Chen:
> Currently we are adding all of the attached devices' clocks as pm clocks
> and enable them when powering on the power domain.
> 
> This seems unnecessary, because those clocks are already controlled in
> the devices' drivers with better error handling.
> 
> Tested on my chromebook minnie(rk3288) and chromebook kevin(rk3399).
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>

Looks ok to me and does not seem to interfere with the synchronous
reset that still stays intact.

@Ceasar: any objections?


Heiko