linux-kernel - [PATCH v3 2/2] fs/sysctl: remove redundant link check in proc_sys_link_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180228013506.4915-2-danilokrummrich@dk-develop.de>
Date:   Wed, 28 Feb 2018 02:35:06 +0100
From:   Danilo Krummrich <danilokrummrich@...develop.de>
To:     mcgrof@...nel.org, keescook@...omium.org, akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Danilo Krummrich <danilokrummrich@...develop.de>
Subject: [PATCH v3 2/2] fs/sysctl: remove redundant link check in proc_sys_link_fill_cache()

proc_sys_link_fill_cache() does not need to check whether we're
called for a link - it's already done by scan().

Acked-by: Kees Cook <keescook@...omium.org>
Signed-off-by: Danilo Krummrich <danilokrummrich@...develop.de>
---
v2: removed 'err' as it's only used for sysctl_follow_link()
v3: add ack
---
 fs/proc/proc_sysctl.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 82ac5f682b73..d36ef667c0a8 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -712,12 +712,9 @@ static bool proc_sys_link_fill_cache(struct file *file,
 	if (IS_ERR(head))
 		return false;
 
-	if (S_ISLNK(table->mode)) {
-		/* It is not an error if we can not follow the link ignore it */
-		int err = sysctl_follow_link(&head, &table);
-		if (err)
-			goto out;
-	}
+	/* It is not an error if we can not follow the link ignore it */
+	if (sysctl_follow_link(&head, &table))
+		goto out;
 
 	ret = proc_sys_fill_cache(file, ctx, head, table);
 out:
-- 
2.14.1