linux-kernel - Re: [linux-sunxi] [PATCH v2 3/4] ARM: dts: add pwm status for r40.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0fd023da-214a-c4ef-63f7-0cc41ca716bf@arm.com>
Date:   Wed, 28 Feb 2018 01:54:57 +0000
From:   André Przywara <andre.przywara@....com>
To:     hao5781286@...il.com, thierry.reding@...il.com, robh+dt@...nel.org,
        mark.rutland@....com, wens@...e.org,
        maxime.ripard@...e-electrons.com
Cc:     linux@...linux.org.uk, Claudiu.Beznea@...rochip.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-pwm@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [linux-sunxi] [PATCH v2 3/4] ARM: dts: add pwm status for r40.

Hi,

the subject line should mention the BananaPi M2 Ultra board.

Otherwise this looks good, although I wonder if this should somehow
mention "LCD-PWM" (in the commit message?), since this is how this pin
is described in the BananaPi GPIO documentation for this board.
And it seems to be dedicated for this purpose here.

Cheers,
Andre.

On 25/02/18 13:52, hao_zhang wrote:
> This patch adds pwm status for r40.
> 
> Signed-off-by: hao_zhang <hao5781286@...il.com>
> ---
>  arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> index 8c5efe2..e4eb074 100644
> --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> @@ -196,6 +196,12 @@
>  	status = "okay";
>  };
>  
> +&pwm {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pwm_ch0_pin>;
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_pb_pins>;
>