linux-kernel - Re: [PATCH] Documentation: Update ncurses package names for menuconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Mar 2018 00:04:18 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Arvind Prasanna <arvindprasanna@...il.com>
Cc:     Kate Stewart <kstewart@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Documentation: Update ncurses package names for menuconfig

2018-02-28 15:59 GMT+09:00 Arvind Prasanna <arvindprasanna@...il.com>:
> The package name is ncurses-devel for Redhat based distros
> and libncurses-devel for Debian based distros.
>
> Signed-off-by: Arvind Prasanna <arvindprasanna@...il.com>
> ---
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index a10bd9d..4353e40 100755
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -55,7 +55,8 @@ EOF
>             echo " *** required header files."                            1>&2
>             echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
>             echo " *** "                                                  1>&2
> -           echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
> +           echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
> +                  *** depending on your distribution) and try again."    1>&2
>             echo " *** "                                                  1>&2
>             exit 1
>         fi
> --
> 2.7.4


'echo' is missing in the line you added.
So, the error message will be displayed like follows:



 *** Unable to find the ncurses libraries or the
 *** required header files.
 *** 'make menuconfig' requires the ncurses libraries.
 ***
 *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
           *** depending on your distribution) and try again.
 ***




I fixed it up locally, and applied to linux-kbuild/kconfig.
Thanks!





> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Masahiro Yamada