linux-kernel - Re: [PATCH] scsi: qedi: fix build regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1woyx500b.fsf@oracle.com>
Date:   Tue, 27 Feb 2018 21:19:32 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     QLogic-Storage-Upstream@...ium.com,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Manish Rangankar <Manish.Rangankar@...ium.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qedi: fix build regression


Arnd,

> A bugfix I did caused a build regression in some other randconfig
> builds in a rare combination of options:
>
> In file included from drivers/scsi/qedi/qedi_fw.c:16:
> drivers/scsi/qedi/qedi_gbl.h:26:38: error: array type has incomplete element type 'struct qedi_debugfs_ops'
>  extern const struct qedi_debugfs_ops qedi_debugfs_ops[];
>                                       ^~~~~~~~~~~~~~~~
>
> This removes the useless #ifdef around the declarations in qedi_dbg.h
> to make it always build.

Applied to 4.17/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering