linux-kernel - Re: [PATCH v4 01/12] drivers: base: Unified device connection lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d0084b1-77c1-ae2b-1623-a2e1bf4b0c22@redhat.com>
Date:   Wed, 28 Feb 2018 16:06:38 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v4 01/12] drivers: base: Unified device connection lookup

Hi,

On 26-02-18 20:34, Randy Dunlap wrote:
> On 02/26/2018 10:39 AM, Hans de Goede wrote:
>> diff --git a/include/linux/connection.h b/include/linux/connection.h
>> new file mode 100644
>> index 000000000000..0b4430eae53a
>> --- /dev/null
>> +++ b/include/linux/connection.h
>> @@ -0,0 +1,33 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +
>> +#ifndef _LINUX_CONNECTION_H_
>> +#define _LINUX_CONNECTION_H_
>> +
>> +#include <linux/list.h>
>> +
>> +struct device;
>> +
>> +/**
>> + * struct devcon - Device Connection Descriptor
>> + * @endpoint: The names of the two devices connected together
>> + * @id: Unique identifier for the connection
> 
> Hi,
>   * @list: <description>
> is missing above.

Thanks, fixed in v5, which I'm going to send out right
away since there have been no other remarks for the last 24h.

Regards,

Hans



> 
>> + */
>> +struct devcon {
>> +	const char		*endpoint[2];
>> +	const char		*id;
>> +	struct list_head	list;
>> +};
> 
>