linux-kernel - Re: [PATCH V5 2/2] thermal: imx: add i.MX7 thermal sensor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180301212253.fp4gxes57t2m2tg2@rob-hp-laptop>
Date:   Thu, 1 Mar 2018 15:22:53 -0600
From:   Rob Herring <robh@...nel.org>
To:     Anson Huang <Anson.Huang@....com>
Cc:     leonard.crestez@....com, rui.zhang@...el.com, edubezval@...il.com,
        mark.rutland@....com, shawnguo@...nel.org, kernel@...gutronix.de,
        fabio.estevam@....com, linux@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        Linux-imx@....com, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH V5 2/2] thermal: imx: add i.MX7 thermal sensor support

On Thu, Mar 01, 2018 at 07:09:40AM +0800, Anson Huang wrote:
> This patch adds i.MX7 thermal sensor support, most
> of the i.MX7 thermal sensor functions are same with
> i.MX6 except the registers offset/layout, so we move
> those registers offset/layout definitions to soc data
> structure.
> 
> i.MX7 uses single calibration data @25C, the calibration
> data is located at OCOTP offset 0x4F0, bit[17:9], the
> formula is as below:
> 
> Tmeas = (Nmeas - n1) + 25; n1 is the fuse value for 25C.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> Signed-off-by: Bai Ping <ping.bai@....com>
> Acked-by: Dong Aisheng <aisheng.dong@....com>
> Acked-by: Shawn Guo <shawnguo@...nel.org>
> ---
> changes since V4:
> 	drop direct OCOTP register access for i.mx7d since it is a new added platform,
> 	only support reading ocotp values through the ocotp nvmem driver which handles clock.
>  .../devicetree/bindings/thermal/imx-thermal.txt    |   9 +-
>  drivers/thermal/imx_thermal.c                      | 295 ++++++++++++++++-----
>  2 files changed, 239 insertions(+), 65 deletions(-)

Please add ack/reviewed-by's when posting new versions.

Rob