linux-kernel - Re: [PATCH 01/12] parport: ax88796: Delete an error message for a failed memory allocation in parport_ax88796

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdAEEjycTvxb=KLOsBESRfSjio1uDXfY=gR91TxCCOkVg@mail.gmail.com>
Date:   Thu, 1 Mar 2018 12:46:07 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/12] parport: ax88796: Delete an error message for a
 failed memory allocation in parport_ax88796_probe()

On Wed, Feb 7, 2018 at 9:47 PM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>

Greg, just to be sure this series is under your scope.
IIRC it had been sent during merge window, though it looks like your
tty tree doesn't include it yet, while even older patches, which were
sent as well during merge window, made it

> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> ---
>  drivers/parport/parport_ax88796.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/parport/parport_ax88796.c b/drivers/parport/parport_ax88796.c
> index 2fc91ed..ef0aec4 100644
> --- a/drivers/parport/parport_ax88796.c
> +++ b/drivers/parport/parport_ax88796.c
> @@ -281,10 +281,8 @@ static int parport_ax88796_probe(struct platform_device *pdev)
>         int ret;
>
>         dd = kzalloc(sizeof(struct ax_drvdata), GFP_KERNEL);
> -       if (dd == NULL) {
> -               dev_err(_dev, "no memory for private data\n");
> +       if (!dd)
>                 return -ENOMEM;
> -       }
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         if (res == NULL) {
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko