linux-kernel - Re: [PATCH] f2fs: fix to restore whint_mode in ->remount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180301024515.GB18665@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Wed, 28 Feb 2018 18:45:15 -0800
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Chao Yu <yuchao0@...wei.com>
Subject: Re: [PATCH] f2fs: fix to restore whint_mode in ->remount_fs

On 02/28, Chao Yu wrote:
> From: Chao Yu <yuchao0@...wei.com>
> 
> If we fail in ->remount_fs, it needs to restore old whint_mode as other
> mount options.
> 
> Fixes: e25afe01822f ("f2fs: support passing down write hints given by users to block layer")

Hi Chao,

It was not merged, so please allow me to integrate this into the original
patch.

Thanks,

> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
>  fs/f2fs/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 89abe4087e66..8a93f78efca2 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1512,6 +1512,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
>  		sbi->s_qf_names[i] = s_qf_names[i];
>  	}
>  #endif
> +	sbi->whint_mode = old_whint_mode;
>  	sbi->mount_opt = org_mount_opt;
>  	sbi->active_logs = active_logs;
>  	sb->s_flags = old_sb_flags;
> -- 
> 2.14.1.145.gb3622a4ee