linux-kernel - Re: [PATCH v8 1/8] drm/bridge: analogix: Do not use device's drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4651149.oDM8cr11nT@diego>
Date:   Thu, 01 Mar 2018 16:39:18 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     dri-devel@...ts.freedesktop.org
Cc:     Thierry Escande <thierry.escande@...labora.com>,
        Rob Herring <robh+dt@...nel.org>,
        Archit Taneja <architt@...eaurora.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sandy Huang <hjc@...k-chips.com>,
        linux-rockchip@...ts.infradead.org,
        Jeffy Chen <jeffy.chen@...k-chips.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 1/8] drm/bridge: analogix: Do not use device's drvdata

Am Mittwoch, 10. Januar 2018, 17:23:41 CET schrieb Thierry Escande:
> From: Jeffy Chen <jeffy.chen@...k-chips.com>
> 
> The driver that instantiates the bridge should own the drvdata, as all
> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
> owned by its driver struct. Moreover, storing two different pointer
> types in driver data depending on driver initialization status is barely
> a good practice and in fact has led to many bugs in this driver.
> 
> Let's clean up this mess and change Analogix entry points to simply
> accept some opaque struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
> 
> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>
> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
> Reviewed-by: Sean Paul <seanpaul@...omium.org>
> Acked-by: Jingoo Han <jingoohan1@...il.com>
> Acked-by: Archit Taneja <architt@...eaurora.org>

applied to drm-misc-next as it had Reviews/Acks from drm-bridge people

Thanks
Heiko