linux-kernel - Re: [PATCH] efi/libstub: add strrchr function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKv+Gu-sAQ6x8uCNtQjVrc4tzF7FyCBva8A92-Nxc=ciJj1eLA@mail.gmail.com>
Date:   Thu, 1 Mar 2018 15:48:43 +0000
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] efi/libstub: add strrchr function

On 1 March 2018 at 15:27, Rob Herring <robh@...nel.org> wrote:
> libfdt gained a new dependency on strrchr, so copy the implementation
> from lib/string.c.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> Please ack. This is a dependency for dtc/libfdt sync with upstream.
>
>  drivers/firmware/efi/libstub/string.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/drivers/firmware/efi/libstub/string.c b/drivers/firmware/efi/libstub/string.c
> index ed10e3f602c5..c1a7e58a5af7 100644
> --- a/drivers/firmware/efi/libstub/string.c
> +++ b/drivers/firmware/efi/libstub/string.c
> @@ -56,3 +56,20 @@ int strncmp(const char *cs, const char *ct, size_t count)
>         return 0;
>  }
>  #endif
> +
> +#ifndef __HAVE_ARCH_STRRCHR

As discussed over IRC, this #ifndef needs to be dropped.

Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

> +/**
> + * strrchr - Find the last occurrence of a character in a string
> + * @s: The string to be searched
> + * @c: The character to search for
> + */
> +char *strrchr(const char *s, int c)
> +{
> +       const char *last = NULL;
> +       do {
> +               if (*s == (char)c)
> +                       last = s;
> +       } while (*s++);
> +       return (char *)last;
> +}
> +#endif
> --
> 2.14.1
>