linux-kernel - Re: [PATCH] arm64/efi: Make strrchr() available to the EFI namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Mar 2018 17:13:43 +0000
From:   Will Deacon <will.deacon@....com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     Rob Herring <robh@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64/efi: Make strrchr() available to the EFI namespace

On Thu, Mar 01, 2018 at 05:10:38PM +0000, Ard Biesheuvel wrote:
> On 1 March 2018 at 17:08, Will Deacon <will.deacon@....com> wrote:
> > On Thu, Mar 01, 2018 at 10:28:03AM -0600, Rob Herring wrote:
> >> libfdt gained a new dependency on strrchr, so make it available to the
> >> EFI namespace before we update libfdt.
> >>
> >> Thanks to Ard for providing this fix.
> >>
> >> Cc: Catalin Marinas <catalin.marinas@....com>
> >> Cc: Will Deacon <will.deacon@....com>
> >> Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> >> Signed-off-by: Rob Herring <robh@...nel.org>
> >> ---
> >> Please ack. This is a dependency on a dtc upstream sync.
> >
> > Acked-by: Will Deacon <will.deacon@....com>
> >
> > As an aside, I noticed that this __efistub prefixing is also being
> > applied to mapping symbols, so we get crazy stuff like __efistub_$x. I
> > didn't get round to working out whether that's going to be problematic,
> > but maybe it's all fine...
> >
> 
> Ugh. Those mapping symbols.
> 
> We can filter them explicitly in scripts/kallsyms, I guess, or even
> better, get rid of all __efistub_ symbols entirely (since they are
> either aliases or part of __init code)

Yeah, I started hooking into frob_arch_sections, but I didn't have my ELF
hat on so I set it aside for the time being. There were some other weird
symbols that ended up in modules, some of them with unprintable characters
due to gas generating weird local labels too (I think in BUG()).

Will