linux-kernel - Re: [Outreachy kernel] [PATCH] staging: rtl8712: match alignment with open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1803021849200.17455@hadrien>
Date:   Fri, 2 Mar 2018 18:50:52 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
cc:     Larry.Finger@...inger.net,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8712: match alignment
 with open parenthesis



On Fri, 2 Mar 2018, Arushi Singhal wrote:

> This patch fixes the checks reported by checkpatch.pl for alignment
> should match open parenthesis.
>
> Signed-off-by: Arushi Singhal <arushisinghal@...il.com>

Your Signed-off-by email address should be the same as the one in the From
line.  You have arushisinghal19971997@...il.com.

The commit log should be in the imperative and should explain what you did
and not just what you fixed.  Try to start the commit log message with
"Add".

The change looks fine.

julia

> ---
>  drivers/staging/rtl8712/mlme_linux.c | 2 +-
>  drivers/staging/rtl8712/os_intfs.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
> index 3c7c4a4..baaa52f 100644
> --- a/drivers/staging/rtl8712/mlme_linux.c
> +++ b/drivers/staging/rtl8712/mlme_linux.c
> @@ -36,7 +36,7 @@ static void sitesurvey_ctrl_handler(struct timer_list *t)
>  {
>  	struct _adapter *adapter =
>  		from_timer(adapter, t,
> -			mlmepriv.sitesurveyctrl.sitesurvey_ctrl_timer);
> +			   mlmepriv.sitesurveyctrl.sitesurvey_ctrl_timer);
>
>  	_r8712_sitesurvey_ctrl_handler(adapter);
>  	mod_timer(&adapter->mlmepriv.sitesurveyctrl.sitesurvey_ctrl_timer,
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index e7df5d7..d6d27da 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -230,7 +230,7 @@ struct net_device *r8712_init_netdev(void)
>  static u32 start_drv_threads(struct _adapter *padapter)
>  {
>  	padapter->cmdThread = kthread_run(r8712_cmd_thread, padapter, "%s",
> -			      padapter->pnetdev->name);
> +					  padapter->pnetdev->name);
>  	if (IS_ERR(padapter->cmdThread))
>  		return _FAIL;
>  	return _SUCCESS;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180302173619.GA8598%40seema-Inspiron-15-3567.
> For more options, visit https://groups.google.com/d/optout.
>