linux-kernel - Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMxuvax-g_FUT+7g=+D6CC+XNKftgmeas9JR_bPAUDG9wuqUEA@mail.gmail.com>
Date:   Fri, 2 Mar 2018 19:09:48 +0100
From:   Marc-André Lureau <marcandre.lureau@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Dave Young <dyoung@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, Baoquan He <bhe@...hat.com>,
        Sergio Lopez Pascual <slp@...hat.com>,
        "Somlo, Gabriel" <somlo@....edu>, xiaolong.ye@...el.com,
        Andrew Morton <akpm@...ux-foundation.org>,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>,
        Tony Luck <tony.luck@...el.com>,
        Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()

Hi

On Fri, Mar 2, 2018 at 7:03 PM, Michael S. Tsirkin <mst@...hat.com> wrote:
> On Fri, Mar 02, 2018 at 10:32:04AM +0800, Dave Young wrote:
>> Hi
>>
>> On 02/28/18 at 04:06pm, Marc-André Lureau wrote:
>> > The following patch is going to use the symbol from the fw_cfg module,
>> > to call the function and write the note location details in the
>> > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note.
>> >
>> > CC: Andrew Morton <akpm@...ux-foundation.org>
>> > CC: Baoquan He <bhe@...hat.com>
>> > CC: Dave Young <dyoung@...hat.com>
>> > CC: Dave Young <dyoung@...hat.com>
>>
>> Above duplicated a CC, btw, I remember both Baoquan and me acked it
>> before, you can find the old email and carry the acked-by.
>
> I fixed it but all this is submitter's job really.

Thanks, my bad, I missed it from v6.

>
>> > CC: Hari Bathini <hbathini@...ux.vnet.ibm.com>
>> > CC: Tony Luck <tony.luck@...el.com>
>> > CC: Vivek Goyal <vgoyal@...hat.com>
>> > Signed-off-by: Marc-André Lureau <marcandre.lureau@...hat.com>
>> > Acked-by: Gabriel Somlo <somlo@....edu>
>> > ---
>> >  kernel/crash_core.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
>> > index 4f63597c824d..a93590cdd9e1 100644
>> > --- a/kernel/crash_core.c
>> > +++ b/kernel/crash_core.c
>> > @@ -376,6 +376,7 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void)
>> >  {
>> >     return __pa(vmcoreinfo_note);
>> >  }
>> > +EXPORT_SYMBOL(paddr_vmcoreinfo_note);
>> >
>> >  static int __init crash_save_vmcoreinfo_init(void)
>> >  {
>> > --
>> > 2.16.1.73.g5832b7e9f2
>> >
>>
>> Thanks
>> Dave