linux-kernel - Re: [PATCH 2/2] leaking_addresses: check if file name contains address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180302001349.buaus74hx3xjoaqs@cisco>
Date:   Thu, 1 Mar 2018 17:13:49 -0700
From:   Tycho Andersen <tycho@...ho.ws>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Kernel Hardening <kernel-hardening@...ts.openwall.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] leaking_addresses: check if file name contains
 address

On Fri, Mar 02, 2018 at 09:03:20AM +1100, Tobin C. Harding wrote:
> Sometimes files may be created by using output from printk.  As the scan
> traverses the directory tree we should parse each path name and check if
> it is leaking an address.
> 
> Add check for leaking address on each path name.
> 
> Suggested-by: Tycho Andersen <tycho@...ho.ws>

Acked-by: Tycho Andersen <tycho@...ho.ws>

> Signed-off-by: Tobin C. Harding <me@...in.cc>
> ---
>  scripts/leaking_addresses.pl | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index 65a65aa64d26..a550c9bc34f5 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addresses.pl
> @@ -463,6 +463,16 @@ sub parse_file
>  	close $fh;
>  }
>  
> +# Checks if the actual path name is leaking a kernel address.
> +sub check_path_for_leaks
> +{
> +	my ($path) = @_;
> +
> +	if (may_leak_address($path)) {
> +		printf("Path name may contain address: $path\n");
> +	}
> +}
> +
>  # Recursively walk directory tree.
>  sub walk
>  {
> @@ -484,6 +494,8 @@ sub walk
>  
>  			next if (skip($path));
>  
> +			check_path_for_leaks($path);
> +
>  			if (-d $path) {
>  				push @dirs, $path;
>  				next;
> -- 
> 2.7.4
>