linux-kernel - Re: [RFC][PATCH 03/10] x86/mm: introduce "default" kernel PTE mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa314a3b-88fb-45d0-8e3a-bab2236b3a20@linux.intel.com>
Date:   Fri, 23 Feb 2018 15:46:56 -0800
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     Tom Lendacky <thomas.lendacky@....com>,
        Nadav Amit <namit@...are.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "keescook@...gle.com" <keescook@...gle.com>,
        "hughd@...gle.com" <hughd@...gle.com>,
        "jgross@...e.com" <jgross@...e.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [RFC][PATCH 03/10] x86/mm: introduce "default" kernel PTE mask

On 02/22/2018 03:11 PM, Tom Lendacky wrote:
>> I don't think we can help out-of-tree modules getting this wrong.
>> They're OK if they use PAGE_KERNEL*, btw.
> You will probably need to change __default_kernel_pte_mask to be an
> EXPORT_SYMBOL instead of an EXPORT_SYMBOL_GPL for (some) out-of-tree
> modules.

As much as I detest missing an opportunity to kick non-GPL drivers in
the shins, I guess it is pretty cruel to break them for doing things
like vmap(PAGE_KERNEL).

I'll make it plain EXPORT_SYMBOL().