linux-kernel - Re: [PATCH 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <584282a9-225c-0000-06bd-c07c0ae55007@huawei.com>
Date:   Fri, 2 Mar 2018 09:36:37 +0000
From:   John Garry <john.garry@...wei.com>
To:     Rob Herring <robh@...nel.org>
CC:     <jejb@...ux.vnet.ibm.com>, <martin.petersen@...cle.com>,
        <mark.rutland@....com>, <linux-scsi@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linuxarm@...wei.com>,
        <linux-kernel@...r.kernel.org>, Xiaofei Tan <tanxiaofei@...wei.com>
Subject: Re: [PATCH 1/8] dt-bindings: scsi: hisi_sas: add an property of
 signal attenuation

On 01/03/2018 21:40, Rob Herring wrote:
> On Tue, Feb 20, 2018 at 03:13:24AM +0800, John Garry wrote:
>> From: Xiaofei Tan <tanxiaofei@...wei.com>
>>
>> For some new boards with hip07 chipset we are required to
>> set PHY config registers differently. The hw property which
>> determines how to set these registers is in the PHY signal
>> attenuation readings.
>>
>> This patch add an devicetree property, signal-attenuation, which
>> is used to describe the signal attenuation of an board.
>>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Signed-off-by: Xiaofei Tan <tanxiaofei@...wei.com>
>> Signed-off-by: John Garry <john.garry@...wei.com>
>> ---
>>  Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> index df3bef7..bd32ecd 100644
>> --- a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> +++ b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> @@ -53,6 +53,13 @@ Main node required properties:
>>  Optional main node properties:
>>   - hip06-sas-v2-quirk-amt : when set, indicates that the v2 controller has the
>>  			    "am-max-transmissions" limitation.
>> + - signal-attenuation : array of 3 32-bit values, containing de-emphasis,
>
> Needs a vendor prefix.

Fine, I can add it. It's going to be "hisilicon-signal-attenuation" or 
similar.

Thanks,
John

>
>> +		preshoot, and boost attenuation readings for the board. They
>> +		are used to describe the signal attenuation of the board. These
>> +		values' range is 7600 to 12400, and used to represent -24dB to
>> +		24dB.
>> +		The formula is "y = (x-10000)/10000". For example, 10478
>> +		means 4.78dB.
>>
>>  Example:
>>  	sas0: sas@...00000 {
>> --
>> 1.9.1
>>
>
> .
>