linux-kernel - [PATCH] gpio: raspberrypi-exp: explain Kconfig dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <3c3b8755d186b1f762081ee18efb718886814e51.1519984021.git.baruch@tkos.co.il>
Date:   Fri,  2 Mar 2018 11:47:01 +0200
From:   Baruch Siach <baruch@...s.co.il>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Stefan Wahren <stefan.wahren@...e.com>,
        Dave Stevenson <dave.stevenson@...pberrypi.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Baruch Siach <baruch@...s.co.il>, Arnd Bergmann <arnd@...db.de>
Subject: [PATCH] gpio: raspberrypi-exp: explain Kconfig dependency

Commit 7ed915059c3001 (gpio: raspberrypi-ext: fix firmware dependency)
fixed the Kconfig dependency to ensure that gpio-raspberrypi-exp is not
built-in when the firmware is a module. But the Kconfig syntax for doing
so is cryptic. Add a comment to make it a little easier.

Cc: Arnd Bergmann <arnd@...db.de>
Signed-off-by: Baruch Siach <baruch@...s.co.il>
---
 drivers/gpio/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 52a8b0a6f4e1..1bb25c1ff2d8 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -126,6 +126,8 @@ config GPIO_RASPBERRYPI_EXP
 	tristate "Raspberry Pi 3 GPIO Expander"
 	default RASPBERRYPI_FIRMWARE
 	depends on OF_GPIO
+	# Make sure not 'y' when RASPBERRYPI_FIRMWARE is 'm'. This can only
+	# happen when COMPILE_TEST=y, hence the added !RASPBERRYPI_FIRMWARE.
 	depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)
 	help
 	  Turn on GPIO support for the expander on Raspberry Pi 3 boards, using
-- 
2.16.1