linux-kernel - Re: [PATCH][next] ieee802154: remove unused variable 'val'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc14d4c6-e58a-ab13-ad75-efc71ff454e8@osg.samsung.com>
Date:   Fri, 2 Mar 2018 11:41:00 +0100
From:   Stefan Schmidt <stefan@....samsung.com>
To:     Colin King <colin.king@...onical.com>,
        Xue Liu <liuxuenetmail@...il.com>,
        Alexander Aring <alex.aring@...il.com>,
        linux-wpan@...r.kernel.org, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ieee802154: remove unused variable 'val'

Hello.


On 03/01/2018 03:40 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Variable 'val' is not being initialized and is later being logically
> or'd with DAR_PHY_CTRL4_PROMISCUOUS. Considering this variable is never
> being read anyway we may as well remove val altogether.
>
> Cleans up error detected by cppcheck:
> drivers/net/ieee802154/mcr20a.c:732: (error) Uninitialized variable: val
>
> Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ieee802154/mcr20a.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index d9eb22a52551..55a22c761808 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -723,13 +723,11 @@ mcr20a_set_promiscuous_mode(struct ieee802154_hw *hw, const bool on)
>  	struct mcr20a_local *lp = hw->priv;
>  	int ret;
>  	u8 rx_frame_filter_reg = 0x0;
> -	u8 val;
>  
>  	dev_dbg(printdev(lp), "%s(%d)\n", __func__, on);
>  
>  	if (on) {
>  		/* All frame types accepted*/
> -		val |= DAR_PHY_CTRL4_PROMISCUOUS;
>  		rx_frame_filter_reg &= ~(IAR_RX_FRAME_FLT_FRM_VER);
>  		rx_frame_filter_reg |= (IAR_RX_FRAME_FLT_ACK_FT |
>  				  IAR_RX_FRAME_FLT_NS_FT);

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt