linux-kernel - Re: [PATCH v2 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f62130c-723a-c9ab-533b-48e8addf3dba@huawei.com>
Date:   Fri, 2 Mar 2018 16:10:41 +0000
From:   John Garry <john.garry@...wei.com>
To:     Rob Herring <robh+dt@...nel.org>
CC:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Mark Rutland <mark.rutland@....com>,
        <linux-scsi@...r.kernel.org>, <devicetree@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Xiaofei Tan <tanxiaofei@...wei.com>
Subject: Re: [PATCH v2 1/8] dt-bindings: scsi: hisi_sas: add an property of
 signal attenuation

On 02/03/2018 15:57, Rob Herring wrote:
> On Fri, Mar 2, 2018 at 9:06 AM, John Garry <john.garry@...wei.com> wrote:
>> > From: Xiaofei Tan <tanxiaofei@...wei.com>
>> >
>> > For some new boards with hip07 chipset we are required to
>> > set PHY config registers differently. The hw property which
>> > determines how to set these registers is in the PHY signal
>> > attenuation readings.
>> >
>> > This patch add an devicetree property, hisi-signal-attenuation,
>> > which is used to describe the signal attenuation of an board.
>> >
>> > Cc: Rob Herring <robh+dt@...nel.org>
>> > Cc: Mark Rutland <mark.rutland@....com>
>> > Signed-off-by: Xiaofei Tan <tanxiaofei@...wei.com>
>> > Signed-off-by: John Garry <john.garry@...wei.com>
>> > ---
>> >  Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 7 +++++++
>> >  1 file changed, 7 insertions(+)
>> >
>> > diff --git a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> > index df3bef7..6f6876a 100644
>> > --- a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> > +++ b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> > @@ -53,6 +53,13 @@ Main node required properties:
>> >  Optional main node properties:
>> >   - hip06-sas-v2-quirk-amt : when set, indicates that the v2 controller has the
>> >                             "am-max-transmissions" limitation.
>> > + - hisi-signal-attenuation : array of 3 32-bit values, containing de-emphasis,
> The format for vendor prefixes is: <vendor prefix>,property-name
>
> And should only be ones defined in vendor-prefixes.txt

Hi Rob,

To save a v4, that would be "hisilicon,signal-attenuation", right?

Thanks,
John

>
>> > +               preshoot, and boost attenuation readings for the board. They
>> > +               are used to describe the signal attenuation of the board. These