linux-kernel - Re: [Outreachy kernel] [PATCH] staging: rtlwifi: Remove nonessential semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 3 Mar 2018 20:30:19 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rtlwifi: Remove nonessential
 semicolon



On Sun, 4 Mar 2018, Arushi Singhal wrote:

> Remove non-essential semicolon after 'else' and 'switch' statements. Issue
> found using semicolon.cocci Coccinelle script.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

It seems strange that someone would write code like that...

julia

> ---
>  drivers/staging/rtlwifi/base.c               | 6 +++---
>  drivers/staging/rtlwifi/phydm/phydm_rainfo.c | 1 -
>  2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index c947def..eea0003 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
> @@ -710,20 +710,20 @@ u8 rtl_mrate_idx_to_arfr_id(
>  			ret = RATEID_IDX_BGN_40M_1SS;
>  		else
>  			ret = RATEID_IDX_BGN_40M_2SS;
> -		; break;
> +		break;
>  	case RATR_INX_WIRELESS_N:
>  	case RATR_INX_WIRELESS_NG:
>  		if (rtlphy->rf_type == RF_1T1R)
>  			ret = RATEID_IDX_GN_N1SS;
>  		else
>  			ret = RATEID_IDX_GN_N2SS;
> -		; break;
> +		break;
>  	case RATR_INX_WIRELESS_NB:
>  		if (rtlphy->rf_type == RF_1T1R)
>  			ret = RATEID_IDX_BGN_20M_1SS_BN;
>  		else
>  			ret = RATEID_IDX_BGN_20M_2SS_BN;
> -		; break;
> +		break;
>  	case RATR_INX_WIRELESS_GB:
>  		ret = RATEID_IDX_BG;
>  		break;
> diff --git a/drivers/staging/rtlwifi/phydm/phydm_rainfo.c b/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
> index 8c08c76..e10a91a 100644
> --- a/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
> +++ b/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
> @@ -142,7 +142,6 @@ void odm_c2h_ra_para_report_handler(void *dm_void, u8 *cmd_buf, u8 cmd_len)
>  				     "SGI_support =", cmd_buf[7]);
>  			ODM_RT_TRACE(dm, ODM_FW_DEBUG_TRACE, "%5s  %d\n",
>  				     "Rate_ID =", cmd_buf[8]);
> -			;
>  		}
>  		ODM_RT_TRACE(dm, ODM_FW_DEBUG_TRACE,
>  			     "-------------------------------\n");
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180303190913.GA4555%40seema-Inspiron-15-3567.
> For more options, visit https://groups.google.com/d/optout.
>