linux-kernel - Re: [PATCH] cpu_pm: add syscore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Mar 2018 17:23:13 -0800
From:   "dbasehore ." <dbasehore@...omium.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        alex.shi@...aro.org, Brian Norris <briannorris@...omium.org>,
        Marc Zyngier <marc.zyngier@....com>
Subject: Re: [PATCH] cpu_pm: add syscore_suspend error handling

On Thu, Mar 1, 2018 at 12:39 AM, Sebastian Andrzej Siewior
<bigeasy@...utronix.de> wrote:
> On 2018-02-28 19:27:54 [-0800], Derek Basehore wrote:
>> If cpu_cluster_pm_enter() fails, cpu_pm_exit() should be called. This
>> will put the CPU in the correct state to resume from the failure.
>
> Was this triggered or found on review? Either way it was introduced in
>   6f3eaec87b6b ("cpu_pm: call notifiers during suspend")
> and I might need a stable tag.

It was found during review. I was able to verify that this is a bug,
though. The Rockchip RK3399 doesn't use cluster idle except during
suspend. If I just return an error for cpu_cluster_pm_enter, the
machine wedges. Including this patch makes it error out of suspend
gracefully.

>
>> Signed-off-by: Derek Basehore <dbasehore@...omium.org>
>
> Sebastian