linux-kernel - Re: [PATCH v7 1/5] x86: devicetree: fix config option around x86_flattree_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Mar 2018 08:20:41 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Frank Rowand <frowand.list@...il.com>
cc:     Rob Herring <robh+dt@...nel.org>, pantelis.antoniou@...sulko.com,
        Pantelis Antoniou <panto@...oniou-consulting.com>,
        Ivan Gorinov <ivan.gorinov@...el.com>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, geert@...ux-m68k.org,
        laurent.pinchart+renesas@...asonboard.com
Subject: Re: [PATCH v7 1/5] x86: devicetree: fix config option around
 x86_flattree_get_config()

On Sat, 3 Mar 2018, Frank Rowand wrote:

> On 03/03/18 16:17, frowand.list@...il.com wrote:
> > From: Frank Rowand <frank.rowand@...y.com>
> > 
> > x86_flattree_get_config() is incorrectly protected by
> > ifdef CONFIG_OF_FLATTREE.  It uses of_get_flat_dt_size(), which
> > only exists if CONFIG_OF_EARLY_FLATTREE.  This issue has not
> > been exposed previously because OF_FLATTREE did not occur unless
> > it was selected by OF_EARLY_FLATTREE.  A devicetree overlay change
> > is selecting OF_FLATTREE directly instead of indirectly enabling
> > it by selecting OF_EARLY_FLATTREE.
> > 
> > This problem was exposed by a randconfig generated by the kbuild
> > test robot, where Platform OLPC was enabled.  OLPC selects
> > OF_PROMTREE instead of OF_EARLY_FLATREE.  The only other x86
> > platform that selects OF is X86_INTEL_CE, which does select
> > OF_EARLY_FLATTREE.
> > 
> > Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> > ---
> > 
> > x86 Maintainers, please ack this patch for Rob to accept

Acked-by: Thomas Gleixner <tglx@...utronix.de>