linux-kernel - Re: [Outreachy kernel] [PATCH] staging: comedi: "dont" is changed to "don't"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 4 Mar 2018 13:01:42 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
cc:     abbotti@....co.uk,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: comedi: "dont" is changed
 to "don't"



On Sun, 4 Mar 2018, Arushi Singhal wrote:

> "dont" is changed to "don't" in messages, "dont" is not correct
> english.

The change is fine, but please rewrite the commit log in the imperative.

julia

>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> ---
>  drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +-
>  drivers/staging/comedi/drivers/das16.c       | 2 +-
>  drivers/staging/comedi/drivers/das16m1.c     | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index c007500..ceef905 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -1700,7 +1700,7 @@ static void i2c_write(struct comedi_device *dev, unsigned int address,
>  	 * eeprom and i2c bus
>  	 */
>
> -	/* make sure we dont send anything to eeprom */
> +	/* make sure we don't send anything to eeprom */
>  	devpriv->plx_control_bits &= ~PLX_CNTRL_EECS;
>
>  	i2c_stop(dev);
> diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c
> index 74ff204..81eb51b 100644
> --- a/drivers/staging/comedi/drivers/das16.c
> +++ b/drivers/staging/comedi/drivers/das16.c
> @@ -619,7 +619,7 @@ static int das16_cmd_test(struct comedi_device *dev, struct comedi_subdevice *s,
>
>  	/* Step 2b : and mutually compatible */
>
> -	/*  make sure scan_begin_src and convert_src dont conflict */
> +	/*  make sure scan_begin_src and convert_src don't conflict */
>  	if (cmd->scan_begin_src == TRIG_FOLLOW && cmd->convert_src == TRIG_NOW)
>  		err |= -EINVAL;
>  	if (cmd->scan_begin_src != TRIG_FOLLOW && cmd->convert_src != TRIG_NOW)
> diff --git a/drivers/staging/comedi/drivers/das16m1.c b/drivers/staging/comedi/drivers/das16m1.c
> index 72f8ed2..4e36377 100644
> --- a/drivers/staging/comedi/drivers/das16m1.c
> +++ b/drivers/staging/comedi/drivers/das16m1.c
> @@ -407,7 +407,7 @@ static void das16m1_handler(struct comedi_device *dev, unsigned int status)
>  		if (num_samples > cmd->stop_arg * cmd->chanlist_len)
>  			num_samples = cmd->stop_arg * cmd->chanlist_len;
>  	}
> -	/*  make sure we dont try to get too many points if fifo has overrun */
> +	/*  make sure we don't try to get too many points if fifo has overrun */
>  	if (num_samples > DAS16M1_AI_FIFO_SZ)
>  		num_samples = DAS16M1_AI_FIFO_SZ;
>  	insw(dev->iobase, devpriv->ai_buffer, num_samples);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180304105732.GA24762%40seema-Inspiron-15-3567.
> For more options, visit https://groups.google.com/d/optout.
>