linux-kernel - Re: [PATCH] Bluetooth: btqcomsmd: Fix channel open check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180304195527.GP93895@bjorns-mbp-2.lan>
Date:   Sun, 4 Mar 2018 11:55:27 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Bluez mailing list <linux-bluetooth@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btqcomsmd: Fix channel open check

On Tue 27 Feb 22:25 PST 2018, Marcel Holtmann wrote:
> > 	btq->cmd_channel = qcom_wcnss_open_channel(wcnss, "APPS_RIVA_BT_CMD",
> > 						   btqcomsmd_cmd_callback, btq);
> > -	if (IS_ERR(btq->cmd_channel))
> > -		return PTR_ERR(btq->cmd_channel);
> > +	if (!btq->cmd_channel)
> > +		return -ENOENT;
> 
> Any reason not to fix qcom_wcnss_open_channel to use PTR_ERR?
> 

Not that I can come up with, and obviously I did expect it to do so in
the past. I'll do that.

Thanks,
Bjorn