linux-kernel - Re: [PATCH v2] proc: fix /proc/*/map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180304205317.GB6757@uranus.lan>
Date:   Sun, 4 Mar 2018 23:53:17 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        xemul@...tuozzo.com
Subject: Re: [PATCH v2] proc: fix /proc/*/map_files lookup some more

On Sun, Mar 04, 2018 at 12:51:30AM +0300, Alexey Dobriyan wrote:
> I totally forgot that _parse_integer() accepts arbitrary amount of
> leading zeroes leading to the following lookups:
> 
> 		OK
> 	# readlink /proc/1/map_files/56427ecba000-56427eddc000
> 	/lib/systemd/systemd
> 
> 		bogus
> 	# readlink /proc/1/map_files/00000000000056427ecba000-56427eddc000
> 	/lib/systemd/systemd
> 	# readlink /proc/1/map_files/56427ecba000-00000000000056427eddc000
> 	/lib/systemd/systemd
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
Reviewed-by: Cyrill Gorcunov <gorcunov@...il.com>