[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180305223328.la462hdwwsymvusk@rob-hp-laptop>
Date: Mon, 5 Mar 2018 16:33:28 -0600
From: Rob Herring <robh@...nel.org>
To: Jolly Shah <jolly.shah@...inx.com>
Cc: matthias.bgg@...il.com, andy.gross@...aro.org, shawnguo@...nel.org,
geert+renesas@...der.be, bjorn.andersson@...aro.org,
sean.wang@...iatek.com, m.szyprowski@...sung.com,
michal.simek@...inx.com, mark.rutland@....com, rajanv@...inx.com,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Jolly Shah <jollys@...inx.com>
Subject: Re: [PATCH 1/2] dt-bindings: soc: Add ZynqMP PM bindings
On Tue, Feb 27, 2018 at 03:24:25PM -0800, Jolly Shah wrote:
> Add documentation to describe Xilinx ZynqMP power management
> bindings.
>
> Signed-off-by: Jolly Shah <jollys@...inx.com>
> Signed-off-by: Rajan Vaja <rajanv@...inx.com>
> ---
> .../bindings/soc/xilinx/xlnx,zynqmp-power.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,zynqmp-power.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xlnx,zynqmp-power.txt b/Documentation/devicetree/bindings/soc/xilinx/xlnx,zynqmp-power.txt
> new file mode 100644
> index 0000000..5b7d963
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/xilinx/xlnx,zynqmp-power.txt
> @@ -0,0 +1,28 @@
> +Xilinx Zynq MPSoC Power Management Device Tree Bindings
> +
> +The zynqmp-power node describes the power management configurations.
That really tells me nothing. What aspect of power management does this
interface control?
> +
> +Required properties:
> + - compatible : Must contain: "xlnx,zynqmp-power"
> + - mbox-names : Name given to channels seen in the 'mboxes' property.
> + "rx" - Mailbox corresponding to receive path
> + "tx" - Mailbox corresponding to transmit path
> + - mboxes : Standard property to specify a Mailbox. Each value of
> + the mboxes property should contain a phandle to the
> + mailbox controller device node and an args specifier
> + that will be the phandle to the intended sub-mailbox
> + child node to be used for communication. See
> + Documentation/devicetree/bindings/mailbox/mailbox.txt
> + for more details about the generic mailbox controller
> + and client driver bindings. Also see
> + Documentation/devicetree/bindings/mailbox/ \
> + xlnx,zynqmp-ipi-mailbox.txt for typical controller that
> + is used to communicate with this System controllers.
No need to define a standard property here. Just need to say how many
entries and refer to the common binding.
> +
> +Examples:
> + zynqmp_power: zynqmp-power {
> + compatible = "xlnx,zynqmp-power";
> + mboxes = <&ipi_mailbox_pmu0 0>,
> + <&ipi_mailbox_pmu0 1>;
> + mbox-names = "tx", "rx";
> + };
> --
> 2.7.4
>
Powered by blists - more mailing lists