linux-kernel - Re: [tip:WIP.sched/core 19/22] kernel/sched/core.c:2836:18: error: passing argument 1 of 'mips_install_watch_registers' from incompatible pointer type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180305071253.xgmpj6a5orleb6pa@gmail.com>
Date:   Mon, 5 Mar 2018 08:12:54 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
        linux-kernel@...r.kernel.org, tipbuild@...or.com
Subject: Re: [tip:WIP.sched/core 19/22] kernel/sched/core.c:2836:18: error:
 passing argument 1 of 'mips_install_watch_registers' from incompatible
 pointer type


* Randy Dunlap <rdunlap@...radead.org> wrote:

> >    kernel//sched/core.c:2836:2: note: in expansion of macro 'switch_to'
> >      switch_to(prev, next, prev);
> >      ^~~~~~~~~
> >    arch/mips/include/asm/watch.h:15:6: note: expected 'struct task_struct *' but argument is of type 'struct task_struct *'
> >     void mips_install_watch_registers(struct task_struct *t);
> >          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    cc1: some warnings being treated as errors
> 
> I don't have a tip git repo, but it looks like this would fix it (based on most
> recent -next):
> 
> --- linux-next-20180302.orig/arch/mips/include/asm/watch.h
> +++ linux-next-20180302/arch/mips/include/asm/watch.h
> @@ -12,6 +12,8 @@
>  
>  #include <asm/mipsregs.h>
>  
> +struct task_struct;
> +
>  void mips_install_watch_registers(struct task_struct *t);
>  void mips_read_watch_registers(void);
>  void mips_clear_watch_registers(void);

Yeah, so MIPS wasn't the only arch affected - so I fixed it by restoring the 
original header order.

Thanks,

	Ingo