linux-kernel - Re: [PATCH] soc: rockchip: power-domain: Add a sanity check on pd->num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0a0c26a-885e-72fb-3ce9-96944f137227@rock-chips.com>
Date:   Mon, 5 Mar 2018 17:33:31 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, shawn.lin@...k-chips.com,
        Heiko Stuebner <heiko@...ech.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-rockchip@...ts.infradead.org,
        Elaine Zhang <zhangqing@...k-chips.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] soc: rockchip: power-domain: Add a sanity check on
 pd->num_clks

Hi Jeffy,

On 2018/3/5 17:17, Jeffy Chen wrote:
> The of_count_phandle_with_args() can fail and return error(for example,
> rk3399 pd_vio doesn't have clocks). That would break the pd probe.
> 
> Add a sanity check on pd->num_clks to avoid that.
> 
> Fixes: 65084121d59d ("soc: rockchip: power-domain: use clk_bulk APIs")
> Reported-by: Shawn Lin <shawn.lin@...k-chips.com>
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
Tested-by: Shawn Lin <shawn.lin@...k-chips.com>