linux-kernel - Re: [PATCH 07/11] Staging: iio: accel: Adjust arguments to match open parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Mar 2018 13:16:10 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Himanshu Jha <himanshujha199640@...il.com>
Cc:     jic23@...nel.org, devel@...verdev.osuosl.org,
        daniel.baluta@...il.com, lars@...afoo.de,
        Michael.Hennerich@...log.com, linux-iio@...r.kernel.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        pmeerw@...erw.net, knaack.h@....de
Subject: Re: [PATCH 07/11] Staging: iio: accel: Adjust arguments to match
 open parentheses

On Mon, Mar 05, 2018 at 01:19:26PM +0530, Himanshu Jha wrote:
> In adis16201_read_raw() adjust an argument to match an open parentheses
> using tabs.
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
> ---
>  drivers/staging/iio/accel/adis16201.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
> index 907fb85..1737708 100644
> --- a/drivers/staging/iio/accel/adis16201.c
> +++ b/drivers/staging/iio/accel/adis16201.c
> @@ -110,7 +110,7 @@ static int adis16201_read_raw(struct iio_dev *indio_dev,
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW:
>  		return adis_single_conversion(indio_dev, chan,
> -				ADIS16201_ERROR_ACTIVE, val);
> +						ADIS16201_ERROR_ACTIVE, val);

It still doesn't line up.  You need to use some spaces.

		return adis_single_conversion(indio_dev, chan,
					      ADIS16201_ERROR_ACTIVE, val);

[tab][tab][tab][tab][tab][space][space][space][space][space][space]ADIS...

regards,
dan carpenter