linux-kernel - RE: [PATCH v7] tpm: cmd_ready command can be issued only after granting locality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422E57E@hasmsx108.ger.corp.intel.com>
Date:   Mon, 5 Mar 2018 18:07:19 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC:     Jason Gunthorpe <jgg@...pe.ca>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v7] tpm: cmd_ready command can be issued only after
 granting locality


> 
> On Mon, Mar 05, 2018 at 07:51:28PM +0200, Jarkko Sakkinen wrote:
> > On Mon, Mar 05, 2018 at 01:34:49PM +0200, Tomas Winkler wrote:
> > > The correct sequence is to first request locality and only after
> > > that perform cmd_ready handshake, otherwise the hardware will drop
> > > the subsequent message as from the device point of view the
> > > cmd_ready handshake wasn't performed. Symmetrically locality has to
> > > be relinquished only after going idle handshake has completed, this
> > > requires that go_idle has to poll for the completion and as well
> > > locality relinquish has to poll for completion so it is not
> > > overridden in back to back commands flow.
> > >
> > > Two wrapper functions are added (request_locality
> > > relinquish_locality) to simplify the error handling.
> > >
> > > The issue is only visible on devices that support multiple localities.
> > >
> > > Fixes: 877c57d0d0ca ("tpm_crb: request and relinquish locality 0")
> > > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> >
> > Tested-by: Jarkko Sakkinen <jarkko.sakkine@...ux.intel.com>
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkine@...ux.intel.com>
> 
> This commit has been applied.

Appreciated.
Tomas